Adjusted customizable logo size #9166
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9166 +/- ##
===========================================
+ Coverage 73.31% 73.33% +0.01%
===========================================
Files 448 448
Lines 45862 45868 +6
Branches 3914 3915 +1
===========================================
+ Hits 33626 33637 +11
+ Misses 12236 12231 -5
|
klakhov
reviewed
Mar 4, 2025
| @@ -34,8 +34,6 @@ | |||
|
|
|||
| img { | |||
| object-fit: contain; | |||
| width: 100%; | |||
There was a problem hiding this comment.
It seems that without a static container width and width: 100% on the image, object-fit: contain doesn't work as expected. As a result, logos larger than 128px won't be scaled down to fit but will be clipped instead.
There was a problem hiding this comment.
Added max-width, max-height css props
There was a problem hiding this comment.
However it breaks the implementation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.