Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra sliders on the GT management pages #9168

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RavinduWeerakoon
Copy link
Contributor

Motivation and context

Closes #9158

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link

sonarqubecloud bot commented Mar 4, 2025

@@ -172,6 +172,10 @@ $excluded-background: #d9d9d973;
.ant-tabs-content-holder, .ant-tabs-content, .ant-tabs-tabpane {
height: 100%;
}

.ant-tabs-tabpane-active{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider my comment here.
Hiding overflow will not make any good to us as some information will be clipped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I saw your comment after putting the PR. If the mentioned rule isn't required, let's remove it. But changing the overflow didn't clip any information as you have thought, since the inside div is still scrollable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra sliders on the GT management pages
2 participants