Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SimilarityTransform3 and switch to colmap::Sim3d #117

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Jan 6, 2025

  • Use colmap::Sim3d and remove the SimilarityTransform3 implementation from limap. This is healthier in the long term as COLMAP is maintained more extensively.
  • move Rotation3d, Rigid3d, and Sim3d from pycolmap to limap.base.pycolmap. This is needed before we enable wheels since the two packages are not necessarily built on the same platform. Add pycolmap/helpers.h to third-party.
  • Increment colmap tag to the newest version

Example:

import limap
import limap.util.io as limapio
imagecols = limap.base.ImageCollection(limapio.read_npy(filepath).item())
sim3d = limap.base.pycolmap.Sim3d()
sim3d.scale = 2.0
imagecols_transformed = imagecols.apply_similarity_transform(sim3d) # The camera positions are scaled by 2.0.

@B1ueber2y B1ueber2y requested review from MarkYu98 and rpautrat January 6, 2025 23:16
@B1ueber2y B1ueber2y merged commit f3a9e52 into main Jan 7, 2025
5 checks passed
@B1ueber2y B1ueber2y deleted the features/colmap_sim3 branch January 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants