Skip to content

Commit

Permalink
Added release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
Christiaan van Tienhoven committed Jan 26, 2018
1 parent 70c3583 commit 8b3e313
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ When creating or editing a rule, the schedule(s) for generating report(s) can be
- Moved report subscriber option to the Report Schedules screen
- Introduced alerting via the native Graylog Alarm Callbacks (Notifications)

2.2.1
-----

- Bugfix: fixed NullPointerException in AggregatesMaintenance when rule has no alertConditionId. Also log a warning when this is the case.



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ private void resolveOrphanedAlerts() {
if (rule.getAlertConditionId() != null && !streamIds.contains(rule.getStreamId())) {
streamIds.add(rule.getStreamId());
}

if (rule.getAlertConditionId() == null){
LOG.warn("Rule [{}] has no associated AlertCondition, perhaps it was created with an old version of the plugin. Please re-create it to be able to generate alerts.", rule.getName());
}
}

LOG.info("Removing Aggregate Alert Conditions that don't have associated rule.");
Expand Down Expand Up @@ -166,7 +170,7 @@ private void resolveOrphanedAlerts() {
if (streamService.getAlertCondition(triggeredStream, alertConditionId).getType().equals(AggregatesUtil.ALERT_CONDITION_TYPE)) {
Rule foundRule = null;
for (Rule rule : rules) {
if (rule.getAlertConditionId().equals(alertConditionId)) {
if (alertConditionId.equals(rule.getAlertConditionId())) {
foundRule = rule;
break;
}
Expand Down

0 comments on commit 8b3e313

Please sign in to comment.