Fix UI windows visibility setting on close. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user quits the game using 'quit' and then closes the client (e.g. with alt-f4) the window positions and visibility will be saved when OgreClient::Cleanup() is called. Because the client is not in game mode, all UI visibility will be saved as not visible. The fix is to check if the game is in UIMode::Playing prior to saving setting visibility in config for saving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user quits the game using 'quit' and then closes the client (e.g.
with alt-f4) the window positions and visibility will be saved when
OgreClient::Cleanup() is called. Because the client is not in game mode,
all UI visibility will be saved as not visible. The fix is to check if
the game is in UIMode::Playing prior to saving setting visibility in
config for saving.