⬆️ v3.9.0...v3.10.1

.eslintrc.js

@@ -1,7 +1,7 @@
 module.exports = {
   root: true,
   parserOptions: {
-    ecmaVersion: 2017,
+    ecmaVersion: 2018,
     sourceType: 'module',
   },
   plugins: ['ember'],

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set Node.js
         uses: actions/setup-node@master
         with:
-          node-version: 10.24.1
+          node-version: 12.22.8
 
       - name: Get yarn cache
         id: yarn-cache

.tool-versions

@@ -1 +1 @@
-nodejs 10.24.1
+nodejs 12.22.8

.travis.yml

@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - '6'
+  - '8'
 
 sudo: false
 dist: trusty

README.md

@@ -19,6 +19,7 @@ a _vanilla_ port of Gruber's original works.
 
 - Ember.js v2.18 or above
 - Ember CLI v2.13 or above
+- Node.js v8 or above
 
 ## Installation
 

addon/components/set-links-target.js

@@ -34,6 +34,9 @@ export default Component.extend({
       // got this far, then apply a target if it hasn't already got one
       if (isEmpty(element.getAttribute('target'))) {
         element.setAttribute('target', targetValue);
+        if (targetValue === '_blank') {
+          element.setAttribute('rel', 'noopener noreferrer');
+        }
       }
     });
   },

package.json

@@ -48,7 +48,7 @@
   "dependencies": {
     "ember-auto-import": "^1.5.3",
     "ember-cli-babel": "^7.26.11",
-    "ember-cli-htmlbars": "^3.0.0",
+    "ember-cli-htmlbars": "^3.0.1",
     "lodash.startswith": "^4.2.1",
     "showdown": "^1.9.1"
   },
@@ -59,7 +59,7 @@
     "bootstrap-sass": "^3.4.3",
     "bootswatch": "^3.4.1",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-cli": "~3.9.0",
+    "ember-cli": "~3.10.1",
     "ember-cli-dependency-checker": "^3.1.0",
     "ember-cli-deploy": "^1.0.2",
     "ember-cli-deploy-build": "^2.0.0",
@@ -79,7 +79,7 @@
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-qunit": "^4.6.0",
     "ember-resolver": "^8.0.3",
-    "ember-source": "~3.9.0",
+    "ember-source": "~3.10.0",
     "ember-source-channel-url": "^3.0.0",
     "ember-try": "^2.0.0",
     "eslint-plugin-ember": "^7.0.0",
@@ -91,7 +91,7 @@
     "sass": "~1.48.0"
   },
   "engines": {
-    "node": "6.* || 8.* || >= 10.*"
+    "node": "8.* || >= 10.*"
   },
   "ember-addon": {
     "configPath": "tests/dummy/config"

tests/dummy/config/ember-cli-update.json

@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.9.0",
+      "version": "3.10.1",
       "blueprints": [
         {
           "name": "addon",

tests/integration/components/set-links-target-test.js

@@ -20,13 +20,24 @@ module('Integration | Component | set links target', function (hooks) {
     assert.equal(find('.set-links-target').innerHTML.trim(), '<h3 id="heading3">Heading 3</h3>');
   });
 
+  test('when the yield link(s) have target set to _top', async function (assert) {
+    await render(hbs`
+      {{#set-links-target targetValue="_top"}}
+        {{marked-down "[Some Link](http://github.com)"}}
+      {{/set-links-target}}
+    `);
+    assert.dom('a').hasAttribute('target', '_top');
+    assert.dom('a').hasNoAttribute('rel');
+  });
+
   test('when the yields link(s) do not have a target value, _blank is added', async function (assert) {
     await render(hbs`
       {{#set-links-target}}
         {{marked-down "[Some Link](http://github.com)"}}
       {{/set-links-target}}
     `);
     assert.dom('a').hasAttribute('target', '_blank');
+    assert.dom('a').hasAttribute('rel', 'noopener noreferrer');
   });
 
   test('when excludeSelfLinks is false, the target is applied to local links', async function (assert) {
@@ -36,6 +47,7 @@ module('Integration | Component | set links target', function (hooks) {
       {{/set-links-target}}
     `);
     assert.dom('a').hasAttribute('target', '_blank');
+    assert.dom('a').hasAttribute('rel', 'noopener noreferrer');
   });
 
   test('when excludeSelfLinks defaults to true, the target is not applied to such links', async function (assert) {
@@ -46,6 +58,7 @@ module('Integration | Component | set links target', function (hooks) {
       {{/set-links-target}}
     `);
     assert.dom('a').hasNoAttribute('target');
+    assert.dom('a').hasNoAttribute('rel');
   });
 
   test('when excludeSelfLinks is explicitly set to true, the target is not applied to such links', async function (assert) {
@@ -56,6 +69,7 @@ module('Integration | Component | set links target', function (hooks) {
       {{/set-links-target}}
     `);
     assert.dom('a').hasNoAttribute('target');
+    assert.dom('a').hasNoAttribute('rel');
   });
 
   test('when the target is set for one of several links', async function (assert) {
@@ -66,6 +80,8 @@ module('Integration | Component | set links target', function (hooks) {
       {{/set-links-target}}
     `);
     assert.dom('a').hasNoAttribute('target');
+    assert.dom('a').hasNoAttribute('rel');
     assert.dom(findAll('a')[1]).hasAttribute('target', '_blank');
+    assert.dom(findAll('a')[1]).hasAttribute('rel', 'noopener noreferrer');
   });
 });