Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a looked at the skia_2024 branch and tried to create an interface to be able to update an image from a data structure.
I don't know if it's a good idea to have rgba32 (uint32_t) as a pixel format. This makes the user of the library tackle the endian issue as shown in the example below. If we instead have a pixel format rgba as an uint8_t[4] this will no longer be an issue.
Note that in this PR 'make_pixmap' for rgba32 takes a pointer to uint8_t, not uint32_t. This makes the point of having these template friend functions less relevant.
Not sure how strict you want to follow the skia_branch so some guidance would be appreciated.