Enhance code readability with detailed comments for find_output.rs

[Gudnessuche]

This adds helpful comments throughout the Rust code, making it easier to understand and maintain. The comments explain the purpose of each function, variable, and constant, as well as provide context for key operations in the code.

[Gudnessuche]

After re-reading the entire thing, noticed that the Receiver object might need to maintain the "silentpayments::utils::Network::Testnet", as opposed to just "Network::Testnet"

No?

[cygnet3]

Yep it needs to be a Network type of the crate itself. The silentpayment Network type refers to the network of the address in question (so starting with sp1, tsp1orsprt1. But these do not map 1:1 with the bitcoin::Network. For example, tsp1` is used for both Testnet and Signet.

If you fix that, I'll merge this too!

[Gudnessuche]

Fixed it.
Quick question tho before you merge. I came across this amazing repo of yours when trying to work on bringing SP to BDK. Have you intended working on that, or working on it currently. Cos what you've done with this, is beyond a Proof of Concept in my humble opinion.

[cygnet3]

That's a good question, we are currently not working on a BDK integration but that is not out of the question. With the current work being done to add a BIP352 module to libsecp, the future of this library is a little uncertain.

It is likely that this library will either become more of a high-level silent payments library (basically BDK but for silent payments specifically), or we'll put more effort into merging this library with other existing libraries (e.g. BDK, rust-bitcoin).

[Gudnessuche]

Awesome, did you get to merge this?

[cygnet3]

merged it!