feat: improve rollback mechanism #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b33ngo
approved these changes
Aug 17, 2023
This commit refactors the `event_reader_service.rs` file by introducing a new `Rollback` enum and modifying the `resync_rollback` field in the `EventsReader ` struct to use this enum. The `Rollback` enum is used to specify different types of rollbacks, including `None`, `Beginning`, and `Signature`. The `res ync_rollback` field is now of type `Arc<RwLock<Rollback>>`. Additionally, a new method `reset_last_resynced_transaction` is added to the `ResyncedTransactionsPtrStorage` trait and implemented for the `rocksdb` module . This method allows resetting the last resynced transaction for a specific program ID. These changes improve the clarity and maintainability of the codebase.
cyphersnake
force-pushed
the
improve-rollback-mechanism
branch
from
af95f34 to
fd0fb54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
event_reader_service.rsfile by introducing a newRollbackenum and modifying theresync_rollbackfield in theEventsReaderstruct to use this enum. TheRollbackenum is used to specify differenttypes of rollbacks, including
None,Beginning, andSignature. Theres ync_rollbackfield is now of typeArc<RwLock<Rollback>>.Additionally, a new method
reset_last_resynced_transactionis added to theResyncedTransactionsPtrStoragetrait and implemented for therocksdbmodule. This method allows resetting the last resynced transaction for a specific
program ID.
These changes improve the clarity and maintainability of the codebase.