Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label/tags to cypht #1058

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Conversation

Shadow243
Copy link
Member

@Shadow243 Shadow243 commented Jun 3, 2024

Related issue: #13

Screenshot 2024-06-04 at 11 58 26

@marclaporte marclaporte requested a review from kroky June 3, 2024 21:32
@marclaporte
Copy link
Member

This was requested 9 years ago, so I expect it will make a lot of people happy! #13

Can we envisage that when Cypht is integrated with other apps (like Tiki), it shares tags/labels? We don't need now, but I expect we will want later.

@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch from 1f7a24b to cd5a8fc Compare June 4, 2024 10:00
@Shadow243 Shadow243 marked this pull request as draft June 4, 2024 10:03
@Shadow243
Copy link
Member Author

@Baraka24 @IrAlfred @amaninyumu1 @David-Muhasa @christer77 @Bienvenumoringa I suggest a modal to create instead of Servers page. Means when you click add label we show a modal with that form and ajax handler to save, and close the modal, finally reload the page or just refresh the menu[reload] action.

In show mail we will add an other menu in the list: Label(On click we load tags as dropdowns).
Screenshot 2024-06-04 at 12 45 20

What's your Thoughts?

@kroky
Copy link
Member

kroky commented Jun 5, 2024

Looks good so far. I'll review once this is ready out of draft mode.

@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch 9 times, most recently from 9dd2f41 to 3e5136e Compare July 11, 2024 16:28
@Shadow243 Shadow243 marked this pull request as ready for review July 11, 2024 16:29
@Shadow243
Copy link
Member Author

I'll review once this is ready out of draft mode.

Ready for review @kroky

@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch from 3e5136e to 8d23123 Compare July 13, 2024 01:48
@marclaporte
Copy link
Member

Reading the code, I see both tag and label being used. Please standardize to one.

It's OK to have code comment which indicates the alternative name for searchability.

@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch 4 times, most recently from a2f0ba7 to 8d2ef38 Compare July 16, 2024 09:03
@Shadow243
Copy link
Member Author

Please standardize to one.

@marclaporte I'm now using tag/tags.

@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch 6 times, most recently from 2d581a4 to 980f6d6 Compare July 23, 2024 09:26
@Shadow243 Shadow243 force-pushed the user-tagg-and-labels branch from 980f6d6 to 2a38da6 Compare July 23, 2024 09:46
@marclaporte marclaporte requested a review from kroky August 1, 2024 15:05
@kroky kroky merged commit f20bded into cypht-org:master Aug 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants