-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding label/tags to cypht #1058
Conversation
This was requested 9 years ago, so I expect it will make a lot of people happy! #13 Can we envisage that when Cypht is integrated with other apps (like Tiki), it shares tags/labels? We don't need now, but I expect we will want later. |
1f7a24b
to
cd5a8fc
Compare
@Baraka24 @IrAlfred @amaninyumu1 @David-Muhasa @christer77 @Bienvenumoringa I suggest a modal to create instead of Servers page. Means when you click add label we show a modal with that form and ajax handler to save, and close the modal, finally reload the page or just refresh the menu[reload] action. In show mail we will add an other menu in the list: Label(On click we load tags as dropdowns). What's your Thoughts? |
Looks good so far. I'll review once this is ready out of draft mode. |
9dd2f41
to
3e5136e
Compare
Ready for review @kroky |
3e5136e
to
8d23123
Compare
Reading the code, I see both tag and label being used. Please standardize to one. It's OK to have code comment which indicates the alternative name for searchability. |
a2f0ba7
to
8d2ef38
Compare
@marclaporte I'm now using tag/tags. |
…the tree in the manu
2d581a4
to
980f6d6
Compare
980f6d6
to
2a38da6
Compare
Related issue: #13