Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Added functionality to enable or disable Sieve Filters with toggle button #1104

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[ENH] Added functionality to enable or disable Sieve Filters with toggle button #1104

merged 1 commit into from
Oct 21, 2024

Conversation

amaninyumu1
Copy link
Member

No description provided.

@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch from a8bd54f to b330c2b Compare June 27, 2024 08:57
@josaphatim josaphatim force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch 2 times, most recently from fb9dc09 to 0bd8033 Compare July 2, 2024 15:02
@amaninyumu1 amaninyumu1 marked this pull request as ready for review July 4, 2024 20:04
@marclaporte marclaporte requested a review from Shadow243 July 11, 2024 18:17
Shadow243
Shadow243 requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all tests pass successfully and also remove composer.lock it will be supported by this #1093 because we have some changes that must be applied in sievefilters/modules.php before.

@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch 2 times, most recently from aedb2a1 to fd4fdf2 Compare August 18, 2024 16:02
@marclaporte marclaporte requested a review from Shadow243 August 25, 2024 09:23
@amaninyumu1
Copy link
Member Author

hello @Shadow243 . I deleted the composer.lock file as you requested in your previous comment and all the tests passed successfully. please review

@marclaporte
Copy link
Member

Sorry, but there is another conflict.

@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch from fd4fdf2 to 37133d4 Compare September 12, 2024 18:22
@amaninyumu1
Copy link
Member Author

hello @marclaporte . conflict has been resolved

@marclaporte marclaporte requested a review from kroky September 13, 2024 11:44
marclaporte
marclaporte reviewed Sep 13, 2024
View reviewed changes
kroky
kroky reviewed Sep 16, 2024
View reviewed changes
kroky
kroky reviewed Sep 16, 2024
View reviewed changes
@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch 3 times, most recently from 768e378 to 5929ff7 Compare September 18, 2024 16:24
@amaninyumu1
Copy link
Member Author

Hello @kroky
I added echo json_encode([...]); to send a json response to ajax

@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch 4 times, most recently from 86542ca to 6ccac96 Compare September 20, 2024 08:19
Shadow243
Shadow243 requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that you did a rebase which removed some important behavior. Can you review this PR carefully?

@josaphatim josaphatim force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch from 6ccac96 to dba61b7 Compare October 18, 2024 17:41
@amaninyumu1 amaninyumu1 force-pushed the add-a-toggle-top-activate-deactivate-a-Cypht-Sieve-rule branch from dba61b7 to 1b23ba6 Compare October 19, 2024 19:32
@Shadow243 Shadow243 requested a review from kroky October 19, 2024 19:39
@kroky
Copy link
Member

kroky commented Oct 21, 2024

Looks good now, thanks!

@kroky kroky merged commit 4da09be into cypht-org:master Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclaporte marclaporte marclaporte left review comments

@Shadow243 Shadow243 Shadow243 requested changes

@kroky kroky Awaiting requested review from kroky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amaninyumu1 @marclaporte @kroky @Shadow243 @josaphatim