[NEW] add a modal dialog to warn the user about sending an email without a body

[mercihabam]

Description

Add a warning prompt that's shown when the user is about to send an email with an empty body.

Issues

• Sending an email with no body causes fatal PHP error #866

[PaulTGG]

I found that when the setting is disabled, I was shown a warning, and prevented from sending an email with an empty body. However, when the setting is enabled, trying to send an email with an empty body still crashes php. Here's the last error message.

[Tue Jan 16 10:59:32.513723 2024] [proxy_fcgi:error] [pid 57369] [client 172.16.32.226:60912] AH01071: Got error 't()\n#3 /usr/local/share/testcypht/modules/smtp/hm-mime-message.php(92): Hm_MIME_Msg->prep_message_body()\n#4 /usr/local/share/testcypht/modules/smtp/modules.php(736): Hm_MIME_Msg->get_mime_msg()\n#5 /usr/local/share/testcypht/lib/modules_exec.php(177): Hm_Handler_process_compose_form_submit->process()\n#6 /usr/local/share/testcypht/lib/modules_exec.php(155): Hm_Module_Exec->run_handler_module()\n#7 /usr/local/share/testcypht/lib/dispatch.php(221): Hm_Module_Exec->run_handler_modules()\n#8 /usr/local/share/testcypht/lib/dispatch.php(1...'

[marclaporte]

I don't want one more setting. Just make it that there is warning to the user.

[PaulTGG]

IMHO, giving users the option is never a bad thing (especially when you can just "set it and forget it"), although I might just be saying that because of my use-case.  Either way, the php crash is still happening in the background. Jan 16, 2024 6:07:36 p.m. Marc Laporte ***@***.***>:

…

I don't want one more setting. Just make it that there is warning to the user. — Reply to this email directly, view it on GitHub[#868 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC47L65NECIWOUF3MYKR4G3YO4W35AVCNFSM6AAAAABB3MOWL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUHAYTSMBZGA]. You are receiving this because you commented. [Tracking image][https://github.com/notifications/beacon/AC47L6274WYSNQLKHUZU6YLYO4W35A5CNFSM6AAAAABB3MOWL2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQ6CSRE.gif]

[marclaporte]

Options are more code to maintain. It's one more thing to think about when testing or reporting issues.

I can't think of a real-world use case where someone would regularly and intentionally send emails without a subject or body.

[PaulTGG]

I can't think of a real-world use case where someone would regularly and intentionally send emails without a subject or body.

You clearly don't work with some of my co-workers... lol Lots of subject-only emails flying around!

Could a workaround be to pre-populate the email composer with the signature line? Then as long as the profile has a signature, there would always be something in the email body.

[marclaporte]

Idea: The warning could be:

• Cancel sending (default)
• Send anyway
• Send anyway and don't warn me in the future

The third option would add a cookie to the user's browser.

[mercihabam]

I found that when the setting is disabled, I was shown a warning, and prevented from sending an email with an empty body. However, when the setting is enabled, trying to send an email with an empty body still crashes php. Here's the last error message.

[Tue Jan 16 10:59:32.513723 2024] [proxy_fcgi:error] [pid 57369] [client 172.16.32.226:60912] AH01071: Got error 't()\n#3 /usr/local/share/testcypht/modules/smtp/hm-mime-message.php(92): Hm_MIME_Msg->prep_message_body()\n#4 /usr/local/share/testcypht/modules/smtp/modules.php(736): Hm_MIME_Msg->get_mime_msg()\n#5 /usr/local/share/testcypht/lib/modules_exec.php(177): Hm_Handler_process_compose_form_submit->process()\n#6 /usr/local/share/testcypht/lib/modules_exec.php(155): Hm_Module_Exec->run_handler_module()\n#7 /usr/local/share/testcypht/lib/dispatch.php(221): Hm_Module_Exec->run_handler_modules()\n#8 /usr/local/share/testcypht/lib/dispatch.php(1...'

@PaulTGG which PHP version is your environment using? I did not get any such error when trying this on my side. Could it be related to your PHP version?

[mercihabam]

Idea: The warning could be:

• Cancel sending (default)
• Send anyway
• Send anyway and don't warn me in the future

The third option would add a cookie to the user's browser.

Good.

[PaulTGG]

@PaulTGG which PHP version is your environment using? I did not get any such error when trying this on my side. Could it be related to your PHP version?

@jacob-js I'm using PHP 8.2.7. It's the latest version that's available in the Debian repositories. (Using Debian 12.4.)

[mercihabam]

@PaulTGG which PHP version is your environment using? I did not get any such error when trying this on my side. Could it be related to your PHP version?

@jacob-js I'm using PHP 8.2.7. It's the latest version that's available in the Debian repositories. (Using Debian 12.4.)

Can you please try switching to version 7.4?

[PaulTGG]

Can you please try switching to version 7.4?

I wasn't able to complete the install using PHP 7.4. It's not in the repository of Debian 12, and I tried Debian 11, but composer gave the following error:

require.composer is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$".

Hopefully the PHP version isn't the issue, since 7.4 was end-of-life a little over a year ago!

[mercihabam]

Can you please try switching to version 7.4?

I wasn't able to complete the install using PHP 7.4. It's not in the repository of Debian 12, and I tried Debian 11, but composer gave the following error:

require.composer is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$".

Hopefully the PHP version isn't the issue, since 7.4 was end-of-life a little over a year ago!

@PaulTGG By now, I'm certain you will not get that exception anymore using the PHP version you have.

[PaulTGG]

@PaulTGG By now, I'm certain you will not get that exception anymore using the PHP version you have.

Just tried it, and everything looks good, thanks!