-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: qualify E2E testing scope #797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Locally npm start |
This comment was marked as resolved.
This comment was marked as resolved.
MikeMcC399
force-pushed
the
testing-scope
branch
from
March 1, 2024 10:33
a7f8319
to
cd51be4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
testing-scope
branch
from
March 2, 2024 05:43
cd51be4
to
78ea340
Compare
This comment was marked as resolved.
This comment was marked as resolved.
MikeMcC399
force-pushed
the
testing-scope
branch
from
March 4, 2024 17:22
78ea340
to
0888881
Compare
add link to cypress-io/cypress-realworld-app
MikeMcC399
force-pushed
the
testing-scope
branch
from
March 4, 2024 17:48
0888881
to
71ab7e6
Compare
@MikeMcC399 Is this ready for review? |
Yes, I was just waiting for CI to successfully complete, which it has now done. |
jennifer-shehane
approved these changes
Mar 4, 2024
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The repo description does not take account of the addition of Component Testing to the previously available End-to-End Testing.
cypress-example-kitchensink
provides for E2E Testing only, not Component Testing.The repo also claims that "every API command in Cypress" is tested, which is not completely true.
Changes
The following locations are updated: