-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix: ARM64 - Build Centos7 for sqlite3 dependency #28500
base: develop
Are you sure you want to change the base?
chore: fix: ARM64 - Build Centos7 for sqlite3 dependency #28500
Conversation
|
Note - it may be beneficial to add a linux-arm64-contributor-workflow in the future, to ensure that ARM builds are tested in PR. |
@jsamuel1 thanks for opening this. I think #28374 is a separate issue from this, both having to do with GLIBC. Would you be willing to open a new issue describing what you're seeing related to the better sqlite GLIBC error on Linux ARM? That would help us keep these two issues separate and then we can move forward with testing this change. Thanks |
@astone123 Created issue #28525 |
Hi @astone123 , @jennifer-shehane Is there any updates on this PR ? |
@jsamuel1 Thank you for opening a PR. I have reviewed the linked issue, and I’m not sure this change would fix this issue. This change would fix that error in our CI pipeline, but our CI does not release an image for other to consume. Our docker images are maintained and released in https://github.com/cypress-io/cypress-docker-images. Is it possible this change should be made here instead? https://github.com/cypress-io/cypress-docker-images/blob/master/circle.yml |
@emilyrohrbough I’m looking to fix it for the install package, rather than a docker image, for people that build their own docker images. Are your packages also published from the docker repository? |
@jsamuel1 No, you are correct the Cypress package is published from here. |
Hi @jsamuel1. The issue you are seeing with addon-native.node actually comes from our binary publishing process, which is not done in this repo. We’ll need to make a change there in order to fix this. Right now, that work is not currently scheduled. |
Thanks Ryan. Anything I can do to help with the binary publishing fix, or is it in a private repo? |
@jsamuel1 It's in a private repo |
Hey @ryanthemanuel @jennifer-shehane any timeline when the binary issue will be addressed ? |
@Younis-NAB Sorry, this is not on the list of prioritized work for us atm. |
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
GLIBC_2.29
not found when running in a docker container on a mac with m1 #28374 )Additional details
This change builds the older dependency for sqlite3 on linux-arm64, such that docker containers on arm64 using RHEL7/8 or CENTOS7/8 won't get a glibc version error.
A conditional was added in the sqlite3 centos build, such that the build could proceed on machine workers as well as docker workers.
PR Tasks
cypress-documentation
? NAtype definitions
? NA