-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Security upgrade webpack from 5.88.2 to 5.94.0 #30122
base: develop
Are you sure you want to change the base?
Conversation
…ce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACK-7840298
cypress Run #56864
Run Properties:
|
Project |
cypress
|
Branch Review |
snyk-fix-c603ef5968f6798883d404a5e75181bf
|
Run status |
Failed #56864
|
Run duration | 15m 31s |
Commit |
b04dcfc187: Update protocol snapshots with new stack trace lines
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
8
|
Pending |
1328
|
Skipped |
0
|
Passing |
29395
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.92%
|
|
---|---|
Untested elements |
201
|
Tested elements |
168
|
Accessibility
91.2%
|
|
---|---|
Failed rules |
5 critical
10 serious
2 moderate
2 minor
|
Failed elements |
948
|
Tests for review
src/debug/DebugPageHeader.cy.tsx • 1 failed test • app-ct
Test | Artifacts | |
---|---|---|
An uncaught error was detected outside of a test |
Test Replay
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
... > past Max-Age, before Expires -> not logged in |
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
|
@@ -46,7 +46,7 @@ exports['e2e events'] = ` | |||
"line": 1, | |||
"column": 0, | |||
"whitespace": " ", | |||
"stack": "Error\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:9:1)\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:33:12)\\n at eval (<anonymous>)" | |||
"stack": "Error\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:8:1)\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:32:12)\\n at eval (<anonymous>)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why these stack trace lines require updating. Assume it's a fix?? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webpack changelog: https://github.com/webpack/webpack/releases
I believe we'll need to trigger a release for the package separately as we always do since some other files needed to be touched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more updates needed here.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
npm/webpack-batteries-included-preprocessor/package.json
Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/
directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarn
to update the contents of the./yarn/cache
directory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACK-7840298
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)