Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add type linting + compilation checks to packages #30776

Merged
merged 39 commits into from
Jan 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
bd7156e
chore: add type linting + compilation checks to runner package
jennifer-shehane Dec 17, 2024
b539409
empty commit
jennifer-shehane Dec 17, 2024
20f5552
A bunch of tslint fixes
jennifer-shehane Dec 17, 2024
9a9a471
Merge branch 'develop' into runner-check-ts
jennifer-shehane Dec 17, 2024
37f6367
wow it is building
jennifer-shehane Dec 18, 2024
3f5dff5
Merge branch 'runner-check-ts' of https://github.com/cypress-io/cypre…
jennifer-shehane Dec 18, 2024
498080a
Fix issue with CT not mounting correctly with comments within it
jennifer-shehane Dec 18, 2024
58d11e6
Fix net-stubbing.ct.ts failures
jennifer-shehane Dec 18, 2024
91ca342
Fix tslint: disable comment
jennifer-shehane Dec 18, 2024
a6f8043
move target into compilerOptions
jennifer-shehane Dec 18, 2024
685d816
fix tslint disable comment
jennifer-shehane Dec 18, 2024
9db9e96
update proxy-logging to undo changes
jennifer-shehane Dec 18, 2024
dd574ba
standardize the tslint:disable comments
jennifer-shehane Dec 18, 2024
192b266
fix comment
jennifer-shehane Dec 18, 2024
59493e2
fix the banner content not displaying and write a test for this situa…
jennifer-shehane Dec 19, 2024
c2c5f71
fix ct reference
jennifer-shehane Dec 19, 2024
01fa9cc
put target to es2020
jennifer-shehane Dec 19, 2024
1251de8
actually set the property with replaced title
jennifer-shehane Dec 20, 2024
717fa52
Merge branch 'develop' into runner-check-ts
jennifer-shehane Dec 20, 2024
1daefcf
Update packages/reporter/src/hooks/hook-model.ts
jennifer-shehane Jan 3, 2025
38a9257
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 6, 2025
adb0ff7
merge develop
jennifer-shehane Jan 13, 2025
d9550ad
Fix eslint/tslint settings for system-tests with vue 3
jennifer-shehane Jan 13, 2025
4085c0f
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 17, 2025
f2a9f18
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 17, 2025
5188b9c
bump CI cache
jennifer-shehane Jan 17, 2025
9a63c6c
update types/react resolution
jennifer-shehane Jan 17, 2025
a3e143e
add return
jennifer-shehane Jan 22, 2025
6ae4fb3
lint fix
jennifer-shehane Jan 22, 2025
5307dfd
tslint disable for empty blocks
jennifer-shehane Jan 22, 2025
1af50a6
exclude dist files from ts linting
jennifer-shehane Jan 22, 2025
54538c7
update to exclude all dist folder
jennifer-shehane Jan 22, 2025
a3143fe
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 22, 2025
ff80b12
exclude dist file
jennifer-shehane Jan 22, 2025
e4f7049
Merge branch 'runner-check-ts' of https://github.com/cypress-io/cypre…
jennifer-shehane Jan 22, 2025
4493684
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 23, 2025
88f9b97
change to await
jennifer-shehane Jan 23, 2025
2d58a32
fix line numbers of stack trace with linting updating vue file
jennifer-shehane Jan 23, 2025
148cdb5
Merge branch 'develop' into runner-check-ts
jennifer-shehane Jan 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ct reference
jennifer-shehane committed Dec 19, 2024
commit c2c5f71e2b9f99756c7710d8476d2f9288c396ff
3 changes: 1 addition & 2 deletions packages/app/src/specs/SpecsListBanners.cy.tsx
Original file line number Diff line number Diff line change
@@ -159,8 +159,7 @@ describe('<SpecsListBanners />', { viewportHeight: 260, defaultCommandTimeout: 1

// The ct title has dynamic content and seems complicated to set here, so ignoring
if (defaultMessages.specPage.banners.componentTesting.title) {
// @ts-expect-error
delete defaultMessages.specPage.banners.componentTesting.title
defaultMessages.specPage.banners.componentTesting.title.replace('{0}', 'React')
}

cy.wrap(Object.entries(defaultMessages.specPage.banners[camelCase(bannerTestId)])).each((entry) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this assertion because after my updates, the rendering of the banner content was broken, but I only detected this through Percy. We should have a test that asserts on the content for the future.

Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ describe('<ComponentTestingBanner />', { viewportWidth: 1200 }, () => {
)

cy.findByTestId('alert-prefix-icon').should('be.visible')
cy.contains(defaultMessages.specPage.banners.ct.title.replace('{0}', framework.name)).should('be.visible')
cy.contains(defaultMessages.specPage.banners.componentTesting.title.replace('{0}', framework.name)).should('be.visible')
})
})