Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deps): update examples/nextjs (e2) to v15 #1345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The examples/nextjs was originally created for Next.js 13.x with React 18.x and it was later migrated to Next.js 14.x, also with React 18.x.

Next.js 14.x has been replaced by Next.js 15.x with React 19.x as the latest release.

The current example, using [email protected], reports also a moderate severity vulnerability (CVE-2024-56332).

Change

Regenerate a Next.js 15.x project into the examples/nextjs directory using:

npx create-next-app@latest nextjs --js --tailwind --no-eslint --app --src-dir --turbopack --no-import-alias --use-npm

See CLI create-next-app

Modify the Cypress test according to the new default page content from Vercel Next.js v15.

nextjs update to 15.1.4
react update to 19.0.0
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 20, 2025 09:07
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 Is this example test running in CI? I couldn't quite find it in the github actions.

examples/nextjs/README.md Show resolved Hide resolved
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Is this example test running in CI? I couldn't quite find it in the github actions.

Yes, this example runs in CI

wait-on-nextjs:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Cypress tests
uses: ./
with:
working-directory: examples/nextjs
start: npm run dev
wait-on: 'http://localhost:3000'
wait-using-custom-command:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Cypress tests
uses: ./
with:
working-directory: examples/nextjs
start: npm run dev
# let's use the wait-on npm package to check the URL
wait-on: 'npx wait-on --timeout 60000 http://localhost:3000'

For example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants