Adding epsilon parameter to spherize #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shntnu - do you want to take a look? It is a simple PR, but we might want to continue our pull request review culture. |
shntnu
reviewed
Mar 18, 2021
pycytominer/normalize.py
Outdated
| Returns | ||
| ------- | ||
| pd.DataFrame or None | ||
| The normalized profile DataFrame. If ouput_file="none", then return the |
shntnu
approved these changes
Mar 18, 2021
|
I added a rudimentary test in 835fcc9, primarily to ensure that epsilon is successfully passed as a variable through normalize.py to Spherize(). Going to merge! |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128
Note that I do not test this addition. I added a note to #127 that we need to also test epsilon's effect when we address this more fully.