Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating __about__.py version and fixing pyPI upload action #209

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jun 17, 2022

Description

Bumping the __about__.py version, which fixes the pyPI upload action. I also needed to set skip_existing=True in the github action file.

Related to #207

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@gwaybio
Copy link
Member Author

gwaybio commented Jun 17, 2022

I also removed the author and author email tags in the setup.py

@gwaybio
Copy link
Member Author

gwaybio commented Jun 17, 2022

@staylorx - can you give a quick peek to see if this looks ok to you? I ask you specifically b/c you added the automatic pyPI upload in #188 . Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #209 (2beba2c) into master (f8ce3b4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   95.71%   95.71%   -0.01%     
==========================================
  Files          53       53              
  Lines        2593     2592       -1     
==========================================
- Hits         2482     2481       -1     
  Misses        111      111              
Flag Coverage Δ
unittests 95.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
pycytominer/__about__.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@staylorx
Copy link
Member

Hey @gwaybio, sorry late on this. This looks okay to me. Thanks!

@gwaybio
Copy link
Member Author

gwaybio commented Jun 20, 2022

Perfect, thanks

@gwaybio gwaybio merged commit fcf03b6 into cytomining:master Jun 20, 2022
@gwaybio gwaybio deleted the update-about-version branch June 20, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants