Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #296

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

jenna-tomkinson
Copy link
Member

@jenna-tomkinson jenna-tomkinson commented Jun 14, 2023

modified from EmbeddedArtistry

Description

In this PR, I created YML files that are issue templates for PyCytominer to standardize the issue intake.

This PR is in relation to issue #226.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #296 (a83cb0e) into master (e4c4165) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          57       57           
  Lines        3057     3057           
=======================================
  Hits         2908     2908           
  Misses        149      149           
Flag Coverage Δ
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jenna-tomkinson
Copy link
Member Author

@gwaybio @axiomcura

I just realized I don't have access to adding reviewers to this PR.

Copy link
Member

@axiomcura axiomcura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added some suggestions, feel free to ask me anything!

@jenna-tomkinson
Copy link
Member Author

@axiomcura Thank you for the review!

@d33bs or @gwaybio Please let me know if either of you can review since I assume both of you have write access.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please make the following changes and tag me when you do. I'll then merge. Thanks!

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/documentation_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/general_questions.yml Outdated Show resolved Hide resolved
@jenna-tomkinson
Copy link
Member Author

@gwaybio I have addressed all comments. This should be good to go for merging. Thank you!

@gwaybio gwaybio self-requested a review June 29, 2023 15:59
@gwaybio gwaybio merged commit 7c4f166 into cytomining:master Jun 29, 2023
@jenna-tomkinson jenna-tomkinson deleted the add_issue_templates branch July 7, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants