Merge pull request #165 from mariovyord/fix/icon-can-be-reloaded-afte…

…r-fail fix: enable icon reloading after fetch fail
czeckd · Dec 6, 2024 · 0138b54 · 0138b54
2 parents aaf812d + 929f57d
commit 0138b54
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/projects/angular-svg-icon/src/lib/svg-icon-registry.service.ts b/projects/angular-svg-icon/src/lib/svg-icon-registry.service.ts
@@ -48,12 +48,14 @@ export class SvgIconRegistryService {
 				div.innerHTML = svg;
 				return div.querySelector('svg') as SVGElement;
 			}),
-			tap (svg => this.iconsByUrl.set(name, svg) ),
+			tap(svg => {
+				this.iconsByUrl.set(name, svg);
+				this.iconsLoadingByUrl.delete(name);
+			}),
 			catchError(err => {
 				console.error(err);
 				return observableThrowError(err);
 			}),
-			finalize(() => this.iconsLoadingByUrl.delete(name) ),
 			share()
 		) as Observable<SVGElement>;