Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove hardcoded jwt_secret #480

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: Remove hardcoded jwt_secret #480

wants to merge 5 commits into from

Conversation

divinecharlotte
Copy link
Contributor

@divinecharlotte divinecharlotte commented Jan 6, 2025 •
edited
Loading

Checked if we have JWT_SECRET set in the project

  • I checked if the JWT_SECRET env is set for the project. it seemed hardcoded in some files.

Issue ticket 460 and link

💀 the test is failing due to the absence of JWT_SECRET in GitHub environment variables

Checklist before requesting a review

  • I have performed a self-review of my code
  • No existing features have been broken without good reason.
  • The code style guideline have been followed
  • Documentation has been updated to reflect your changes.

@divinecharlotte divinecharlotte changed the title feat:remove hardcoded jwt_secret feat: Remove hardcoded jwt_secret Jan 6, 2025
@divinecharlotte divinecharlotte linked an issue Jan 7, 2025 that may be closed by this pull request
Check if we have JWT_SECRET set in the project #460
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if we have JWT_SECRET set in the project
1 participant
@divinecharlotte