Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compare-BapEnvironmentD365App function to handle missing source v… #16

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented Mar 4, 2024

…ersions

@FH-Inway FH-Inway requested a review from Splaxi March 4, 2024 15:45
Copy link
Collaborator

@Splaxi Splaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this PR is needed:

Per the begin section, we are only fetching installed Apps from the source environment.

$appsSourceEnvironment = Get-BapEnvironmentD365App -EnvironmentId $SourceEnvironmentId -InstallState Installed -GeoRegion $GeoRegion

But if your testing shows, that we need this change/PR - then please go ahead and merge 👍

@FH-Inway FH-Inway merged commit 0a65900 into development Mar 4, 2024
1 check passed
@FH-Inway
Copy link
Member Author

FH-Inway commented Mar 4, 2024

@Splaxi The issue occurred indeed with one of the environments I have access to. We may need to revisit this sometime and handle packages with a "N/A" version differently. But for now, this should do it.

@FH-Inway FH-Inway deleted the fix-compare-apps-version-na branch March 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants