Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automatic GitHub release creation #21

Conversation

FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented Mar 9, 2024

This extends the build GitHub action by adding a step to automatically create a GitHub release.

As preparation of consolidating all actions shared by the d365collaborative repositories, the actual build steps were moved into a reusable workflow.

To demonstrate the reusable workflow, a new build action was added that can be triggered manually and allows disabling the release creation on both PowerShell gallery and GitHub. This is mainly intended for testing the reusable workflow.

@FH-Inway
Copy link
Member Author

FH-Inway commented Mar 9, 2024

@Splaxi I'm not 100% sure that the transfer of the ApiKey secret works. As far as possible, I tested it on my fork. If it doesn't work, please restore the previous version of build.yml. I will then take a look at setting up an end to end test on my fork.

@FH-Inway FH-Inway requested a review from Splaxi March 9, 2024 18:45
@Splaxi Splaxi merged commit f478ff2 into d365collaborative:development Mar 11, 2024
1 check passed
@FH-Inway
Copy link
Member Author

@Splaxi Note that the input to skip the creation of the GitHub release in the manually triggered action does not work, the release will always be created.

@FH-Inway
Copy link
Member Author

FH-Inway commented Apr 9, 2024

@Splaxi I'm not 100% sure that the transfer of the ApiKey secret works. As far as possible, I tested it on my fork. If it doesn't work, please restore the previous version of build.yml. I will then take a look at setting up an end to end test on my fork.

@Splaxi Seems that worked 😄
Next step see d365collaborative/d365fo.tools#813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants