Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Invoke-D365InstallSqlPackage to install latest version of SQLPackage #817

Merged

Conversation

FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented May 1, 2024

This updates the default version of SqlPackage that d365fo.tools installs to 162.2.111.2 (the first .NET 8 version).

In addition, it replaces the -SkipExtractFromPage parameter and the corresponding web scraping logic with the -Latest parameter and the evergreen link https://aka.ms/sqlpackage-windows

Note that unlike the behavior from when the web scraping logic was still working, the latest version of SqlPackage is NOT installed by default. Instead, the fixed version 162.2.111.2 is installed (which may be updated to later versions in the future). Reasons for this change in behavior are discussed in #747.

The changes also include

  • giving Invoke-Process a return value with the standard and error output
  • Invoke-D365InstallSqlPackage and Invoke-SqlPackage make use of that output to provide information on the SqlPackage version
  • documentation on how to call internal functions of d365fo.tools

FH-Inway added 4 commits May 1, 2024 15:34
This will enable cmdlets that call Invoke-Process to act on the standard and error output of the invoked process.
This updates the default version of SqlPackage that d365fo.tools installs to 162.2.111.2 (the first .NET 8 version).

In addition, it replaces the -SkipExtractFromPage parameter and the corresponding web scraping logic with the -Latest parameter and the evergreen link https://aka.ms/sqlpackage-windows

Note that unlike the behavior from when the web scraping logic was still working, the latest version of SqlPackage is NOT installed by default. Instead, the fixed version 162.2.111.2 is installed (which may be updated to later versions in the future). Reasons for this change in behavior are discussed in d365collaborative#747.

fixes d365collaborative#747
@FH-Inway FH-Inway force-pushed the 747-update-sqlpackage branch from de5b13e to 7a64cbc Compare May 1, 2024 15:54
@FH-Inway FH-Inway marked this pull request as ready for review May 1, 2024 16:02
@FH-Inway FH-Inway requested a review from Splaxi May 1, 2024 16:02
@FH-Inway
Copy link
Member Author

FH-Inway commented May 1, 2024

I do not like trailing spaces...😠

@Splaxi Splaxi merged commit c15d1fe into d365collaborative:development May 2, 2024
11 checks passed
@FH-Inway FH-Inway deleted the 747-update-sqlpackage branch June 22, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants