744 remove azuread dependency #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ➖ ➕ Remove PSNotification, replace AzureAd with Microsoft.Graph #744
FH-Inway
commented
Jun 30, 2024
Comment on lines
+170
to
+175
| $azureADModule = Get-Module -Name "AzureAD" -ListAvailable | ||
| if ($null -eq $azureADModule) { | ||
| Write-PSFMessage -Level Host -Message "AzureAD module is not installed. Trying to install it now." -Color Yellow | ||
| Install-Module -Name "AzureAD" -Force -AllowClobber -Scope CurrentUser | ||
| } | ||
|
|
There was a problem hiding this comment.
❓
@Splaxi What do you think about this "just in time" installation of dependencies? I did not have a chance to fully test it yet.
There was a problem hiding this comment.
Let's have a offline chat at some point in time, over the summer - to see where we end up.
For now I'm against JIT installation...
|
As agreed - I'm taking the task upon me to rewrite the entire cmdlet for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.