Skip to content

Commit

Permalink
dcache-xroot: fix effective root when subject is nobody
Browse files Browse the repository at this point in the history
Motivation:

10545: Xrootd door root path weirdness in 9.2
https://rt.dcache.org/Ticket/Display.html?id=10545

The change to use `effectiveRoot` did not take
into account Subject = Nobody

Modification:

Check first for Subject = Nobody, and if
so, return the door root.

Result:

Regression eliminated, previous behavior
with anonymous read restored.

Target: master
Request: 9.2
Request: 9.1
Bug: #10545
Closes: #10545
Requires-notes: yes
Patch: https://rb.dcache.org/r/14181/
Acked-by: Tigran
  • Loading branch information
alrossi committed Dec 6, 2023
1 parent 4facd1d commit a5d6454
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1399,6 +1399,9 @@ private FsPath createFullPath(String path, Map<String, String> opaque)

private FsPath effectiveRoot() {
LoginSessionInfo loginSessionInfo = sessionInfo();
if (Subjects.isNobody(loginSessionInfo.getSubject())) {
return _rootPath;
}
FsPath userRoot = loginSessionInfo != null ? loginSessionInfo.getUserRootPath() : null;
return userRoot != null ? userRoot : _rootPath;
}
Expand Down

0 comments on commit a5d6454

Please sign in to comment.