cells: ignore empty core domain uris propagated by zk #7698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
When Zookeeper updates core domain infos, dCache will first kill the existing cell tunnels
and then later try to read and parse the new value. If the new value is an empty
string (for whatever reason), parsing will fail, but a new connection will not be
established. The corresponding error in the log:
18 Nov 2024 08:45:00 (c-dcache-head-xxx03_messageDomain-AAYmVA1LtnA-AAYmVA16phA) [dcache-head-xxx03_messageDomain,9.2.21,CORE] Error while reading from tunnel: java.net.SocketExceptio>
18 Nov 2024 08:45:43 (c-dcache-head-xxx03_messageDomain-AAYnKxn40fA) [] Uncaught exception in thread TunnelConnector-dcache-head-xxx03_messageDomain
java.lang.NullPointerException: null
at java.base/java.net.Socket.<init>(Socket.java:448)
at java.base/java.net.Socket.<init>(Socket.java:264)
at java.base/javax.net.DefaultSocketFactory.createSocket(SocketFactory.java:277)
at dmg.cells.network.LocationManagerConnector.connect(LocationManagerConnector.java:64)
at dmg.cells.network.LocationManagerConnector.run(LocationManagerConnector.java:94)
at dmg.cells.nucleus.CellNucleus.lambda$wrapLoggingContext$2(CellNucleus.java:725)
at java.base/java.lang.Thread.run(Thread.java:829)
Modification:
before killing existing tunnel check that ZK didn't propagate empty
data.
Result:
More roust cell communication
NOTE: a non empty invalid data still accepted!!!
Fixes: #7696
Acked-by: Lea Morschel
Target: master, 10.2, 10.1, 10.0, 9.2
Require-book: no
Require-notes: yes
(cherry picked from commit 30829c9)
Signed-off-by: Tigran Mkrtchyan <[email protected]>
kofemann
force-pushed
the
issue-7696-10.1
branch
from
3265bc4 to
81aa9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When Zookeeper updates core domain infos, dCache will first kill the existing cell tunnels and then later try to read and parse the new value. If the new value is an empty string (for whatever reason), parsing will fail, but a new connection will not be established. The corresponding error in the log:
18 Nov 2024 08:45:00 (c-dcache-head-xxx03_messageDomain-AAYmVA1LtnA-AAYmVA16phA) [dcache-head-xxx03_messageDomain,9.2.21,CORE] Error while reading from tunnel: java.net.SocketExceptio>
18 Nov 2024 08:45:43 (c-dcache-head-xxx03_messageDomain-AAYnKxn40fA) [] Uncaught exception in thread TunnelConnector-dcache-head-xxx03_messageDomain java.lang.NullPointerException: null
at java.base/java.net.Socket.(Socket.java:448)
at java.base/java.net.Socket.(Socket.java:264)
at java.base/javax.net.DefaultSocketFactory.createSocket(SocketFactory.java:277)
at dmg.cells.network.LocationManagerConnector.connect(LocationManagerConnector.java:64)
at dmg.cells.network.LocationManagerConnector.run(LocationManagerConnector.java:94)
at dmg.cells.nucleus.CellNucleus.lambda$wrapLoggingContext$2(CellNucleus.java:725)
at java.base/java.lang.Thread.run(Thread.java:829)
Modification:
before killing existing tunnel check that ZK didn't propagate empty data.
Result:
More roust cell communication
NOTE: a non empty invalid data still accepted!!!
Fixes: #7696
Acked-by: Lea Morschel
Target: master, 10.2, 10.1, 10.0, 9.2
Require-book: no
Require-notes: yes
(cherry picked from commit 30829c9)