feat: dts recipe generate boolean 처리 및 리팩토링 (#490)

daangn · Dec 5, 2024 · 5e836e5 · 5e836e5
1 parent bcd2447
commit 5e836e5
Show file tree

Hide file tree

Showing 10 changed files with 36 additions and 34 deletions.
diff --git a/packages/recipe-generator/core/src/dts.ts b/packages/recipe-generator/core/src/dts.ts
@@ -1,43 +1,45 @@
 import { outdent } from "outdent";
 
 import { escapeReservedWord } from "./reserved-words";
-import type { SlotRecipeDefinition, SlotRecipeVariantRecord } from "./types";
+import type { SlotRecipeDefinition, SlotRecipeVariantRecord, StyleObject } from "./types";
 
 const capitalize = (str: string) => str[0].toUpperCase() + str.slice(1);
 
+const isBoolean = (key: string) => ["true", "false"].includes(key);
+
+const stringify = (key: string) => (isBoolean(key) ? key : `"${key}"`);
+
 const generateVariantInterface = (
   variants: SlotRecipeDefinition<string, SlotRecipeVariantRecord<string>>["variants"],
   defaultVariants?: SlotRecipeDefinition<
     string,
     SlotRecipeVariantRecord<string>
   >["defaultVariants"],
 ) => {
-  if (!defaultVariants) {
-    return Object.entries(variants)
-      .map(([variantName, variant]) => {
-        return `${variantName}: ${Object.keys(variant)
-          .map((key) => (["true", "false"].includes(key) ? key : `"${key}"`))
-          .join(" | ")}`;
-      })
-      .join(";\n  ");
-  }
+  const generateVariantType = (
+    variantName: string,
+    // biome-ignore lint/suspicious/noExplicitAny: <explanation>
+    variant: Record<any, Partial<Record<string, StyleObject>>>,
+  ) => {
+    const values = Object.keys(variant);
+    const booleanValues = values.filter(isBoolean);
+    const typeString = booleanValues.length > 0 ? "boolean" : values.map(stringify).join(" | ");
+    const defaultValue = defaultVariants?.[variantName];
 
-  return Object.entries(variants)
-    .map(([variantName, variant]) => {
-      const values = Object.keys(variant)
-        .map((key) => (["true", "false"].includes(key) ? key : `"${key}"`))
-        .join(" | ");
-      const defaultValue = defaultVariants[variantName];
-      if (defaultValue === undefined) {
-        return `${variantName}: ${values};`;
-      }
+    if (defaultValue !== undefined) {
       return outdent`
         /**
-          * @default ${defaultVariants[variantName]}
+          * @default ${defaultValue}
           */
-          ${variantName}: ${values};
+          ${variantName}: ${typeString};
       `;
-    })
+    }
+
+    return `${variantName}: ${typeString};`;
+  };
+
+  return Object.entries(variants)
+    .map(([variantName, variant]) => generateVariantType(variantName, variant))
     .join("\n");
 };
 

diff --git a/packages/recipe/lib/actionChip.d.ts b/packages/recipe/lib/actionChip.d.ts
@@ -1,6 +1,6 @@
 interface ActionChipVariant {
   size: "medium" | "small";
-  layout: "withText" | "iconOnly"
+layout: "withText" | "iconOnly";
 }
 
 type ActionChipVariantMap = {

diff --git a/packages/recipe/lib/badge.d.ts b/packages/recipe/lib/badge.d.ts
@@ -1,8 +1,8 @@
 interface BadgeVariant {
   size: "medium" | "small";
-  shape: "rectangle" | "pill";
-  variant: "soft" | "solid" | "outlined";
-  tone: "neutral" | "brand" | "informative" | "positive" | "danger"
+shape: "rectangle" | "pill";
+variant: "soft" | "solid" | "outlined";
+tone: "neutral" | "brand" | "informative" | "positive" | "danger";
 }
 
 type BadgeVariantMap = {

diff --git a/packages/recipe/lib/checkbox.d.ts b/packages/recipe/lib/checkbox.d.ts
@@ -2,11 +2,11 @@ interface CheckboxVariant {
   /**
   * @default false
   */
-  bold: true | false;
+  bold: boolean;
 /**
   * @default false
   */
-  indeterminate: true | false;
+  indeterminate: boolean;
 /**
   * @default square
   */

diff --git a/packages/recipe/lib/chipTab.d.ts b/packages/recipe/lib/chipTab.d.ts
@@ -1,5 +1,5 @@
 interface ChipTabVariant {
-  variant: "neutralSolid" | "brandSolid"
+  variant: "neutralSolid" | "brandSolid";
 }
 
 type ChipTabVariantMap = {

diff --git a/packages/recipe/lib/chipTabs.d.ts b/packages/recipe/lib/chipTabs.d.ts
@@ -1,5 +1,5 @@
 interface ChipTabsVariant {
-  variant: "neutralSolid" | "brandSolid"
+  variant: "neutralSolid" | "brandSolid";
 }
 
 type ChipTabsVariantMap = {

diff --git a/packages/recipe/lib/controlChip.d.ts b/packages/recipe/lib/controlChip.d.ts
@@ -1,6 +1,6 @@
 interface ControlChipVariant {
   size: "medium" | "small";
-  layout: "withText" | "iconOnly"
+layout: "withText" | "iconOnly";
 }
 
 type ControlChipVariantMap = {

diff --git a/packages/recipe/lib/dialog.d.ts b/packages/recipe/lib/dialog.d.ts
@@ -1,5 +1,5 @@
 interface DialogVariant {
-  footerLayout: "horizontal" | "vertical"
+  footerLayout: "horizontal" | "vertical";
 }
 
 type DialogVariantMap = {

diff --git a/packages/recipe/lib/radio.d.ts b/packages/recipe/lib/radio.d.ts
@@ -1,5 +1,5 @@
 interface RadioVariant {
-  size: "large" | "medium" | "small"
+  size: "large" | "medium" | "small";
 }
 
 type RadioVariantMap = {

diff --git a/packages/recipe/lib/tabs.d.ts b/packages/recipe/lib/tabs.d.ts
@@ -10,7 +10,7 @@ interface TabsVariant {
 /**
   * @default false
   */
-  fixTriggerList: true | false;
+  fixTriggerList: boolean;
 }
 
 type TabsVariantMap = {