Corrected ParserReflect.get_pfunctions on Python 3 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test uses a grammar split into several modules, where the line number of rules are the same in more than one module. This will cause ParserReflect.get_pfunctions to try to sort tuples on module items, which are unsortable in Python 3.
dabeaz
added a commit
that referenced
this pull request
Aug 25, 2015
Corrected ParserReflect.get_pfunctions on Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When p functions from different modules share the same line number, the call to p_functions.sort will compare module instances. This is not supported in Python 3 and will rause TypeError.
This branch fixes this error by converting modules to strs in the sort key argument.