Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak the deployment to improve local dev experience #24

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Tweak the deployment to improve local dev experience #24

merged 2 commits into from
Jan 5, 2024

Conversation

daddykotex
Copy link
Owner

@daddykotex daddykotex commented Jan 5, 2024 •
edited
Loading

Notable changes:

  1. smithy4s-protocol is included in the default image
  2. got rid of backendDependencies, instead, on CI we do two sbt publish with alternate settings to publish two different images
  3. we configure ~reStart so that it loads the dependencies correctly
  4. added a label smithy4s.version to the docker images so we know what smithy4s version is in use in there

@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 5, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ assets/index-(hash).js
 861.29KB (+589B +0.07%) +10%
Unchanged files (1)
Status Path Size Limits
✅ index.html
 318B -

Total files change +591B +0.07%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@daddykotex daddykotex marked this pull request as ready for review January 5, 2024 15:50
@daddykotex daddykotex merged commit 1e6efb8 into main Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daddykotex