Fix: Explicit assertions no longer considered implicit for code actions #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
added
the
run-integration-tests
keyboardDrummer
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6025
What was changed?
Explicit assertions (which as of today are prefixed with ensures and assert) are no longer suggested in code actions where the same expression fails. This was redundant and useless.
How has this been tested?
I added a test for the language server in the assertion case, verified that this test did not pass before the change, and the test passes after the change.
Since ensures are also explicit assertions, I added a test for them as well. However, the test does not work if the ensures is not on the same line as the opening curly brace. I don't know why, but for now I'm writing the test in a way that was surely failing before and now passes.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.