Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the --progress option and rename the --iterations option #6078

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Jan 24, 2025

What was changed?

  • Tweak the --progress option
  • Rename the --iterations option

How has this been tested?

Updated existing tests

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) January 24, 2025 13:15
MikaelMayer
MikaelMayer previously approved these changes Jan 24, 2025
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just prefer to have release notes for this though welcomed renaming, since you are touching what users might already use somewhere.

Source/DafnyCore/Options/CommonOptionBag.cs Show resolved Hide resolved
@@ -1,4 +1,4 @@
// RUN: %exits-with 4 %baredafny measure-complexity --iterations=3 --random-seed=1 --log-format:trx";"LogFileName="%t.trx" "%s"
// RUN: %exits-with 4 %baredafny measure-complexity --mutations=3 --random-seed=1 --log-format:trx";"LogFileName="%t.trx" "%s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change? I'd recommend to document it in a release notes.

@@ -1,4 +1,4 @@
// RUN: ! %verify --progress VerificationJobs --cores=1 %s &> %t.raw
// RUN: ! %verify --progress Batch --cores=1 %s &> %t.raw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, here, if it's a breaking change, please document it in docs/dev/news at least.

@keyboardDrummer
Copy link
Member Author

Added the release notes

@keyboardDrummer keyboardDrummer merged commit 89e44cc into dafny-lang:master Jan 28, 2025
22 checks passed
@keyboardDrummer keyboardDrummer deleted the progressTweak branch January 29, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants