-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak the --progress option and rename the --iterations option #6078
Tweak the --progress option and rename the --iterations option #6078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just prefer to have release notes for this though welcomed renaming, since you are touching what users might already use somewhere.
@@ -1,4 +1,4 @@ | |||
// RUN: %exits-with 4 %baredafny measure-complexity --iterations=3 --random-seed=1 --log-format:trx";"LogFileName="%t.trx" "%s" | |||
// RUN: %exits-with 4 %baredafny measure-complexity --mutations=3 --random-seed=1 --log-format:trx";"LogFileName="%t.trx" "%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change? I'd recommend to document it in a release notes.
@@ -1,4 +1,4 @@ | |||
// RUN: ! %verify --progress VerificationJobs --cores=1 %s &> %t.raw | |||
// RUN: ! %verify --progress Batch --cores=1 %s &> %t.raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, here, if it's a breaking change, please document it in docs/dev/news at least.
Added the release notes |
What was changed?
--progress
option--iterations
optionHow has this been tested?
Updated existing tests
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.