Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gmaps autocomplete #5

Merged
merged 10 commits into from
Aug 7, 2020
Merged

Add gmaps autocomplete #5

merged 10 commits into from
Aug 7, 2020

Conversation

daften
Copy link
Owner

@daften daften commented Aug 3, 2020

No description provided.

@daften daften mentioned this pull request Aug 3, 2020
Merged
Jelle-S
Jelle-S requested changes Aug 4, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Service/GmapsAutocompleteService.php Outdated Show resolved Hide resolved
Jelle-S
Jelle-S requested changes Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@Jelle-S Jelle-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic/code seems sound, one suggestion is a bugfix (missing return statement). Others are code style. In general, but it seems this 'issue' is not contained to this PR: Mixing camelCase and snake_case variable names.

Form/Type/AddressGmapsAutocompleteEmbeddableType.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Service/GmapsAutocompleteService.php Outdated Show resolved Hide resolved
Service/GmapsAutocompleteService.php Outdated Show resolved Hide resolved
Service/GmapsAutocompleteService.php Outdated Show resolved Hide resolved
@daften daften force-pushed the feature/gmaps-autocomplete branch from 2939004 to dda4cb9 Compare August 6, 2020 21:45
@daften daften mentioned this pull request Aug 6, 2020
Open
@daften
Copy link
Owner Author

daften commented Aug 6, 2020

Logic/code seems sound, one suggestion is a bugfix (missing return statement). Others are code style. In general, but it seems this 'issue' is not contained to this PR: Mixing camelCase and snake_case variable names.

Opened issue #6 to fix the coding standards later

@daften
Copy link
Owner Author

daften commented Aug 6, 2020

@Jelle-S Incorporated the changes and made some additional improvements :)

@daften daften merged commit 2916e5d into develop Aug 7, 2020
@daften daften deleted the feature/gmaps-autocomplete branch September 6, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jelle-S Jelle-S Jelle-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daften @Jelle-S