Skip to content

Commit

Permalink
ts: remove temporary standalone sdk (#7600)
Browse files Browse the repository at this point in the history
The tsx issue has been fixed so this isn't needed anymore. Worst case if
something else pops up this SDK would still be usable by it's git commit
ref, so may as well remove it now.

Signed-off-by: Erik Sipsma <[email protected]>
  • Loading branch information
sipsma authored Jun 11, 2024
1 parent 058730d commit c7ac504
Show file tree
Hide file tree
Showing 17 changed files with 0 additions and 9,453 deletions.
26 changes: 0 additions & 26 deletions core/integration/module_typescript_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package core
import (
_ "embed"
"fmt"
"path/filepath"
"testing"

"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -487,31 +486,6 @@ func TestModuleTypescriptOptional(t *testing.T) {
out, err = modGen.With(daggerQuery(`{minimal{isEmpty}}`)).Stdout(ctx)
require.NoError(t, err)
require.JSONEq(t, `{"minimal": {"isEmpty": true}}`, out)

// TODO: minimal test coverage of the workaround for https://github.com/dagger/dagger/issues/7583
// Can be removed once that issue is resolved.
t.Run("standalone ts sdk", func(t *testing.T) {
t.Parallel()

standaloneModPath, err := filepath.Abs("../../sdk/typescript/standalone")
require.NoError(t, err)
standaloneModDir := c.Host().Directory(standaloneModPath)

modGen := c.Container().From(golangImage).
WithMountedFile(testCLIBinPath, daggerCliFile(t, c)).
WithWorkdir("/work").
WithMountedDirectory("/work/standalone-ts", standaloneModDir).
With(daggerExec("init", "--name=minimal", "--sdk=./standalone-ts")).
With(sdkSource("typescript", tsOptional))

out, err := modGen.With(daggerQuery(`{minimal{foo}}`)).Stdout(ctx)
require.NoError(t, err)
require.JSONEq(t, `{"minimal": {"foo": ""}}`, out)

out, err = modGen.With(daggerQuery(`{minimal{isEmpty}}`)).Stdout(ctx)
require.NoError(t, err)
require.JSONEq(t, `{"minimal": {"isEmpty": true}}`, out)
})
}

func TestModuleTypescriptRuntimeDetection(t *testing.T) {
Expand Down
4 changes: 0 additions & 4 deletions sdk/typescript/standalone/.gitattributes

This file was deleted.

4 changes: 0 additions & 4 deletions sdk/typescript/standalone/.gitignore

This file was deleted.

Loading

0 comments on commit c7ac504

Please sign in to comment.