Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation markers for delta patrol duty scenario #2236

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

aBlueShadow
Copy link
Contributor

The gm buttons here are supposed to be removed at certain events, like clicking said button. As there were translation markers for creating the buttons, but not for removal, ramoving does not work for non-english languages. This PR adds the missing marker.
Note for translators: This doesn't add any additional translation strings, so if you have this scenario already translated, there is no additional work to do.

@muerteFR
Copy link
Contributor

muerteFR commented Nov 4, 2024

It is prudent to systematically notify @Xansta when we make small modifications to these scenarios on Daid's repo, so that he takes them into account when he works on these scenarios, otherwise these small modifications will be overwritten by those that 'he does on his side. :-)

@aBlueShadow
Copy link
Contributor Author

I would have assumed that Xansta will regularly merge daids repo from time to time, as keeping an eye on the master repo is important for any kind of change, but a notification will not hurt, of course.

@daid daid merged commit 0c5cc82 into daid:master Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants