Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #7

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Footer #7

merged 4 commits into from
Oct 31, 2024

Conversation

jenniferylee
Copy link
Contributor

@jenniferylee jenniferylee commented Oct 30, 2024

Description

Please provide a summary of the changes made in this pull request:

First draft: updated the footer to show the election box, gold plate, and flag background.

Checklist

  • I have performed a self-review of my own code
  • I have tested changes for mobile, if applicable

Screenshots

Screenshot 2024-10-30 at 1 36 53 AM

Please Include screenshots or links to visual changes for any new component (if applicable).

Copy link
Contributor

@tsakshi011 tsakshi011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the footer looks great so far! A couple of changes that need to be made is the ballot box opening should align with the end of the article grid, and should reach the bottom of the flatpage like in the Figma. In addition, the footer needs to be mobile friendly.

@jenniferylee
Copy link
Contributor Author

Hi! I updated the design of the footer as well as the sizing to be mobile friendly
Screenshot 2024-10-30 at 11 34 53 PM

@tsakshi011 tsakshi011 merged commit 9b321cd into main Oct 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants