chore: bump dependencies #2331
Merged
chore: bump dependencies #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capJavert
commented
Oct 10, 2024
omBratteng
reviewed
Oct 10, 2024
capJavert
commented
Oct 28, 2024
| @@ -67,6 +67,7 @@ export default async function app( | |||
| logger: loggerConfig, | |||
| disableRequestLogging: true, | |||
| trustProxy: true, | |||
| useSemicolonDelimiter: true, | |||
There was a problem hiding this comment.
Not 100% if we use it, I think not, but leaving for BC just in case https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/#usesemicolondelimiter-false-by-default
capJavert
commented
Oct 28, 2024
| "mercurius-upload": "^6.0.1", | ||
| "mercurius": "^15.1.0", | ||
| "mercurius-cache": "^7.0.2", | ||
| "mercurius-upload": "^7.0.0", |
There was a problem hiding this comment.
Looks like tests fail due to mercurius-js/mercurius-upload#24 (comment), hopefully released soon
There was a problem hiding this comment.
patched it now because looks like there are multiple issues mercurius-js/mercurius-upload#13 (comment)
capJavert
commented
Oct 28, 2024
Comment on lines
+3
to
+9
| process.env.NODE_OPTIONS = [ | ||
| process.env.NODE_OPTIONS, | ||
| // https://jestjs.io/docs/ecmascript-modules | ||
| `--experimental-vm-modules`, | ||
| ] | ||
| .filter(Boolean) | ||
| .join(' '); |
There was a problem hiding this comment.
So it works in jest since its using [email protected]
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
omBratteng
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.