feat: move to pnpm #2652
feat: move to pnpm #2652
Conversation
capJavert
commented
Feb 11, 2025
•
capJavert
commented
- also update to node 22
capJavert
force-pushed
the
feat-pnpm
branch
2 times, most recently
from
483929a to
848795b
Compare
| declare module 'fs' { | ||
| interface ReadStream { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| on(event: 'data', listener: (chunk: any) => void): this; | ||
| } | ||
| } |
There was a problem hiding this comment.
In node 22.x types they changed this so its always Buffer so you can't cast it, and since typeorm uses it for query.stream() I overwritten it here to any so we can type it as usual until Node supports generics here.
| @@ -389,7 +389,7 @@ export const schedulePersonalizedDigestSubscriptions = async ({ | |||
|
|
|||
| reject(error); | |||
| }); | |||
| personalizedDigestStream.on('end', resolve); | |||
| personalizedDigestStream.on('end', () => resolve(true)); | |||
There was a problem hiding this comment.
In node 22.x types signature of resolve requires value, so just updating
| "test": "jest --testEnvironment=node --runInBand", | ||
| "typeorm": "typeorm-ts-node-commonjs", | ||
| "postinstall": "patch-package" |
There was a problem hiding this comment.
pnpm has its own patch command
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
| @@ -6,19 +6,21 @@ orbs: | |||
| jobs: | |||
| build: | |||
| docker: | |||
| - image: cimg/node:20.12 | |||
| - image: cimg/node:22.13 | |||
There was a problem hiding this comment.
Should we do 22.11 as apps?
Or move apps over to this as well
There was a problem hiding this comment.
between 22.11 and 22.13 there is no breaking changes, so either way, we can leave everything as is I think
There was a problem hiding this comment.
makes more sense to update apps if we really wanted to
There was a problem hiding this comment.
I just like stuff being the same 😂
Yeah no worries I'll do apps later.
| @@ -1 +1 @@ | |||
| 20.12 | |||
| 22.13 | |||
There was a problem hiding this comment.
Does nvm file not propogate down? 👀
There was a problem hiding this comment.
what do you mean?
There was a problem hiding this comment.
oh you mean because it exists in root, I am not sure, but it was here before so just left it
There was a problem hiding this comment.
Yeah because of root one, and they match.
