Fixed AudioStreamController & StreamController not being cleaned …

…up (video-dev#1751) - `onHandlerDestroying()` is overriden by said controllers but doesn't call `super.onHandlerDestroying()` which cases the tick interval to never stop
dailymotion · Jun 4, 2018 · a7ca28d · a7ca28d
1 parent d4d45d9
commit a7ca28d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/controller/audio-stream-controller.js b/src/controller/audio-stream-controller.js
@@ -62,11 +62,13 @@ class AudioStreamController extends TaskLoop {
 
   onHandlerDestroying () {
     this.stopLoad();
+    super.onHandlerDestroying();
   }
 
   onHandlerDestroyed () {
     this.state = State.STOPPED;
     this.fragmentTracker = null;
+    super.onHandlerDestroyed();
   }
 
   // Signal that video PTS was found

diff --git a/src/controller/stream-controller.js b/src/controller/stream-controller.js
@@ -61,11 +61,13 @@ class StreamController extends TaskLoop {
 
   onHandlerDestroying () {
     this.stopLoad();
+    super.onHandlerDestroying();
   }
 
   onHandlerDestroyed () {
     this.state = State.STOPPED;
     this.fragmentTracker = null;
+    super.onHandlerDestroyed();
   }
 
   startLoad (startPosition) {