-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for non supported vast error #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
docs/api/1.x/parser.md
Outdated
@@ -7,6 +7,8 @@ Whenever an error occurs during the VAST parsing, the parser will call on his ow | |||
|
|||
* VAST error `101`: VAST schema validation error. | |||
|
|||
* VAST error `102`: VAST version of response not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* VAST error `102`: VAST version of response not supported. | |
* VAST error `102`: VAST response version not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I edited the wrong file, this documentation is for old versions 1.x. I moved it to the correct one. The error description comes from IAB https://wiki.iabtechlab.com/index.php?title=VAST_Error_Code_Troubleshooting_Matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
102
VAST version of response not supported.
if it parse a outdated VAST version (only 1.0 for now)303
No VAST response after one or more Wrappers
not being triggered when a wrapper containing a<Creative>
without mediafile (e.g only with a<CompanionAds>
inside) does not result in a VAST response.Issue
#476
Type