Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Readme #34

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Improve Readme #34

merged 1 commit into from
Feb 20, 2024

Conversation

clarissedmn
Copy link
Contributor

@clarissedmn clarissedmn commented Feb 20, 2024 •
edited
Loading

This PR is about improving README :

  • "Build status" Badge is broken

Before :
Capture d’écran 2024-02-20 à 10 16 06

After :
Capture d’écran 2024-02-20 à 10 18 42

  • Fix doc about installation with npm
  • fetch VMAP as XML using the fetch API instead of XMLHttpRequest

ZacharieTFR
ZacharieTFR approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@ZacharieTFR ZacharieTFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for contributing 🏅

rumesh
rumesh approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@rumesh rumesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@clarissedmn clarissedmn merged commit 88ed573 into master Feb 20, 2024
1 check passed
@clarissedmn clarissedmn deleted the improve-readme branch February 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumesh rumesh rumesh approved these changes

@ZacharieTFR ZacharieTFR ZacharieTFR approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarissedmn @rumesh @ZacharieTFR