QR codes for Gora Sail #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dozzod
commented
Dec 10, 2022
|
|
||
| =/ arglist (malt args) | ||
| =/ gor-id=@uv | ||
| :: TODO: @reviewers I replaced this with !! to avoid unwrapping |
There was a problem hiding this comment.
Just use +got:by instead. (Note that this is not a comment on whether crashing on non existence is safe in this context, it’s strictly a code style comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of the gora qr apprenticeship for the sail version. JS Version will follow soon ™️.
This includes a QR encoder fully written in Hoon. The decoder still uses external JS libraries for now.
QRs can be generated from the
/voyerpage with a maximum duration (in hours), with 0 being infinity. Another ship can then claim a code by going to the/pleadpage and pointing their webcam / phone on the QR.The frontend might be a bit clunky, let me know if any improvements can be made or if anything is unclear in general.