Increase node child process maxBuffer setting #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the child process from be killed for long running ffmpeg jobs
qhyun2
changed the title
aroy314
reviewed
Jun 10, 2022
| @@ -12,6 +12,9 @@ module.exports.exec = function (commands, settings, callback) { | |||
| var finalCommand = commands.join(" "); | |||
| // Create the timeoutId for stop the timeout at the end the process | |||
| var timeoutID = null; | |||
|
|
|||
| settings.maxBuffer = 1024*1024*1024*5 // 5 GB, default of child_process lib is : 1024*1024 bytes | |||
|
|
|||
| // Exec the command | |||
| var process = exec(finalCommand, settings, function (error, stdout, stderr) { | |||
There was a problem hiding this comment.
maybe it would be a better idea to change exec() for spawn() ?
https://stackoverflow.com/questions/48698234/node-js-spawn-vs-execute
|
This fixed the issue described in #81 for me! I did run into issues using your forked repository's version of this package. It seems like the node-ffmpeg module on npm hasn't been updated in a few years, and the current repository version does not run properly. So, I actually had to find the last commit before it was published to npm and fork the repository from there. If anyone comes across this issue/PR down the line, this is the repository I created with the correct forked version and fix described above: https://github.com/joshverd/node-ffmpeg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the child process from be killed for long running ffmpeg jobs.
Implemented fix as described in #81