make model consts static

dan-german · Apr 14, 2024 · 81680a1 · 81680a1
1 parent acc7015
commit 81680a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/Source/model/ModelConstants.h b/Source/model/ModelConstants.h
@@ -10,18 +10,16 @@
 
 #pragma once
 
-// #include "model/Module.h"
-
 namespace model {
-const StringArray waveforms { "sine", "was", "saw", "square", "triangle" };
-const std::vector<std::string> modulators { "lfo", "envelope", "random" };
-const StringArray effects { "filter", "drive", "reverb", "delay", "chorus", "flanger", "phaser", "comp" };
-const StringArray tabs { "oscillator", "modulator", "effect" };
-const int rows = 7;
-const int columns = 5;
+static const StringArray waveforms { "sine", "was", "saw", "square", "triangle" };
+static const std::vector<std::string> modulators { "lfo", "envelope", "random" };
+static const StringArray effects { "filter", "drive", "reverb", "delay", "chorus", "flanger", "phaser", "comp" };
+static const StringArray tabs { "oscillator", "modulator", "effect" };
+static const int rows = 7;
+static const int columns = 5;
 
-const std::vector<std::string> block_popup_column_one { "osc", "noise", "filter", "drive", "flanger" };
-const std::vector<std::string> block_popup_column_two { "reverb", "delay", "chorus", "phaser" };
+static const std::vector<std::string> block_popup_column_one { "osc", "noise", "filter", "drive", "flanger" };
+static const std::vector<std::string> block_popup_column_two { "reverb", "delay", "chorus", "phaser" };
 
 constexpr int MAX_MODULES_PER_TYPE = 8;
 }
diff --git a/Source/module_new.h b/Source/module_new.h
@@ -9,9 +9,6 @@
 using ValueScale = vital::ValueDetails::ValueScale;
 
 namespace model {
-
-
-
 class Module {
 public:
   ID id;
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,9 +9,6 @@ @@
     using ValueScale = vital::ValueDetails::ValueScale;
     namespace model {
     class Module {
     public:
       ID id;
@@ Expand Down @@