Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add tabulate naive bayes.md [skip ci] #1318

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Add missing doc page for pcv.tabulate_bayes_classes

Type of update
Is this a:

  • Update to documentation

Associated issues
#1315

Additional context
#1304

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the documentation Documentation issues or features label Aug 1, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Aug 1, 2023
@HaleySchuhl HaleySchuhl self-assigned this Aug 1, 2023
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 August 1, 2023 19:55
@nfahlgren
Copy link
Member

Rather than documenting the function on it's own page, I think we just need to add it to this page: https://plantcv.readthedocs.io/en/stable/tools/. It's used as a command-line tool rather than directly as a function.

@nfahlgren
Copy link
Member

Rather than documenting the function on it's own page, I think we just need to add it to this page: https://plantcv.readthedocs.io/en/stable/tools/. It's used as a command-line tool rather than directly as a function.

Re-upping this

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1318 (74de53b) into release-4.0 (eb77fdf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1318   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       157           
  Lines             6757      6757           
=============================================
  Hits              6757      6757           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit 3cad879 into release-4.0 Aug 10, 2023
5 checks passed
@nfahlgren nfahlgren deleted the ONLY-add-tabulate_naive_bayes.md branch August 10, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants