Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate print results #1327

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Deprecate print results #1327

merged 2 commits into from
Aug 11, 2023

Conversation

nfahlgren
Copy link
Member

Describe your changes
Finishes deprecating pcv.print_results by removing the files and updating the references in the docs to pct.outputs.save_results.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Aug 10, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1327 (372c03d) into release-4.0 (f2eebed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1327   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       156    -1     
  Lines             6777      6772    -5     
=============================================
- Hits              6777      6772    -5     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit 0e4464d into release-4.0 Aug 11, 2023
@nfahlgren nfahlgren deleted the deprecate-print-results branch August 11, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants