Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample label param #1328

Merged
merged 31 commits into from
Aug 14, 2023
Merged

Add sample label param #1328

merged 31 commits into from
Aug 14, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 11, 2023

Describe your changes
Adds a global parameter to Params to set the sample label. The global parameter is the default value for the label parameter for all functions that store data in Outputs. Code is added to each analysis function to set label from params when label=None, but allows label to be overridden by user input. Does not break existing functionality.

Type of update
Is this a: New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added enhancement Enhancements to existing features work in progress Mark work in progress labels Aug 11, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Aug 11, 2023
@nfahlgren
Copy link
Member Author

nfahlgren commented Aug 11, 2023

To do:

  • within_frame
  • homology functions
  • morphology functions
  • updating.md

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1328 (2749a0c) into release-4.0 (151e4ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1328   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              156       156           
  Lines             6772      6829   +57     
=============================================
+ Hits              6772      6829   +57     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/analyze/bound_horizontal.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/bound_vertical.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/color.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/grayscale.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/npq.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/size.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/spectral_index.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/spectral_reflectance.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/thermal.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/yii.py 100.00% <100.00%> (ø)
... and 19 more

@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Aug 11, 2023
@nfahlgren nfahlgren merged commit 6d461dd into release-4.0 Aug 14, 2023
5 checks passed
@nfahlgren nfahlgren deleted the add-sample-label-param branch August 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants