Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-PTC-W0010 #1435

Merged
merged 4 commits into from
Jan 25, 2024
Merged

fix-PTC-W0010 #1435

merged 4 commits into from
Jan 25, 2024

Conversation

k034b363
Copy link
Contributor

Describe your changes
Deepsource identified 3 occurrences of files being opened without the "with ... as" structure. Because this requires the file.close() to explicitly release the file, it is not preferred. This pull request converts those file open lines into the indented "with" structure.

Type of update
Deepsource issue fix

Associated issues
N/A

Additional context
N/A

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fc53c4) 100.00% compared to head (aaa3970) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6944      6943    -1     
=========================================
- Hits          6944      6943    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/learn/naive_bayes.py 100.00% <100.00%> (ø)
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)
plantcv/utils/converters.py 100.00% <100.00%> (ø)

@k034b363 k034b363 added ready to review cleanup Code quality updates labels Jan 22, 2024
@nfahlgren nfahlgren merged commit faed9ed into main Jan 25, 2024
6 checks passed
@nfahlgren nfahlgren deleted the fix-PTC-W0010 branch January 25, 2024 16:47
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

3 participants