-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kmeans grayscale #1570
Merged
Merged
Kmeans grayscale #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
k034b363
added
work in progress
Mark work in progress
and removed
ready to review
labels
Aug 16, 2024
k034b363
added
ready to review
and removed
work in progress
Mark work in progress
labels
Oct 21, 2024
add masks rather than subtracting portions. otherwise there will be a picture frame type border in the mask
k034b363
added
work in progress
Mark work in progress
and removed
ready to review
labels
Oct 23, 2024
k034b363
added
ready to review
and removed
work in progress
Mark work in progress
labels
Oct 24, 2024
annacasto
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
For any previously RGB specific lines in patch_extract() or predict_kmeans(), the added code checks the number of dimensions and number of channels in the image and chooses the RGB or grayscale vesion of the line accordingly. This is a non-breaking feature enhancement that allows grayscale functionality to the preexisting kmeans functions.
Additional update added 10/24/24 by Keely (k034b363), this PR now includes padding the outside edges of images input to
predict_kmeans
so that resulting masks can be applied to the original image. We have included this update here so as to avoid merge in order conflicts.Type of update
Is this a: New feature or feature enhancement
Associated issues
Updated PR now closes: #1552
Additional context
Add any other context about the problem here.
N/A
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md